[Android] [Lists] Workaround a wrong fling direction for inverted ScrollViews on Android P #21117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
mandrigin
force-pushed
the
workaround/fling-on-android-P
branch
2 times, most recently
from
59cf86c
to
107a9ec
Compare
mandrigin
changed the title
chrisnojima
added a commit
to keybase/react-native
that referenced
this pull request
Sep 17, 2018
chrisnojima
added a commit
to keybase/react-native
that referenced
this pull request
Oct 15, 2018
listicos
reviewed
Nov 7, 2018
| // | ||
| // Hence, we can use the absolute value from whatever the OS gives | ||
| // us and use the sign of what mOnScrollDispatchHelper has tracked. | ||
| velocityY = (int)(Math.abs(velocityY) * Math.signum(mOnScrollDispatchHelper.getYFlingVelocity())); |
There was a problem hiding this comment.
I tested this and is working, what is not so good practice in general is changing the argument value, instead create a new var. Thank you for this!
There was a problem hiding this comment.
Thanks for reviewing!
I’m away from my laptop this week, will address you comment on Monday.
There was a problem hiding this comment.
I agree with Ruben's feedback, once the PR is updated I'll try to import it :) Thanks for doing this btw 👏
There was a problem hiding this comment.
Thanks a lot!
Yeah, I agree about a variable, just wanted to make a smallest possible diff.
I fixed it and rebased to the latest master.
|
We will be using this in production until it gets merged! 👍 CC: @listicos who reviewed this for us on our team! |
mandrigin
force-pushed
the
workaround/fling-on-android-P
branch
from
107a9ec
to
f9ed777
Compare
mandrigin
force-pushed
the
workaround/fling-on-android-P
branch
from
f9ed777
to
1ae9b9a
Compare
Generated by 🚫 dangerJS |
chrisnojima
added a commit
to keybase/react-native
that referenced
this pull request
Nov 14, 2018
|
Hey Igor, thanks! I'll try to trigger the import, but can't assure when it will land because this past week the FB team seemed super busy 🤷♂️ @facebook-github-bot shipit |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Nov 15, 2018
There was a problem hiding this comment.
@kelset is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@mandrigin merged commit b971c5b into |
kelset
pushed a commit
that referenced
this pull request
Nov 26, 2018
…d P (#21117) Summary: This is a safe workaround to an issue in Android P: https://issuetracker.google.com/issues/112385925 It is based on a fact that even though `fling` receive a wrong sign in `velocityY`, `mOnScrollDispatchHelper.getYFlingVelocity()` still returns a fling direction. Fixes #19434 Pull Request resolved: #21117 Differential Revision: D13082740 Pulled By: hramos fbshipit-source-id: 1b28586d2c7bdcae4a111d3cead4a0455cebb99a
sjchmiela
pushed a commit
to expo/react-native
that referenced
this pull request
Dec 15, 2018
…d P (facebook#21117) Summary: This is a safe workaround to an issue in Android P: https://issuetracker.google.com/issues/112385925 It is based on a fact that even though `fling` receive a wrong sign in `velocityY`, `mOnScrollDispatchHelper.getYFlingVelocity()` still returns a fling direction. Fixes facebook#19434 Pull Request resolved: facebook#21117 Differential Revision: D13082740 Pulled By: hramos fbshipit-source-id: 1b28586d2c7bdcae4a111d3cead4a0455cebb99a
sjchmiela
pushed a commit
to expo/react-native
that referenced
this pull request
Dec 15, 2018
…d P (facebook#21117) Summary: This is a safe workaround to an issue in Android P: https://issuetracker.google.com/issues/112385925 It is based on a fact that even though `fling` receive a wrong sign in `velocityY`, `mOnScrollDispatchHelper.getYFlingVelocity()` still returns a fling direction. Fixes facebook#19434 Pull Request resolved: facebook#21117 Differential Revision: D13082740 Pulled By: hramos fbshipit-source-id: 1b28586d2c7bdcae4a111d3cead4a0455cebb99a
hramos
removed
the
Import Started
hramos
removed
the
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
…d P (facebook#21117) Summary: This is a safe workaround to an issue in Android P: https://issuetracker.google.com/issues/112385925 It is based on a fact that even though `fling` receive a wrong sign in `velocityY`, `mOnScrollDispatchHelper.getYFlingVelocity()` still returns a fling direction. Fixes facebook#19434 Pull Request resolved: facebook#21117 Differential Revision: D13082740 Pulled By: hramos fbshipit-source-id: 1b28586d2c7bdcae4a111d3cead4a0455cebb99a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a safe workaround to an issue in Android P: https://issuetracker.google.com/issues/112385925
It is based on a fact that even though
flingreceive a wrong sign invelocityY,mOnScrollDispatchHelper.getYFlingVelocity()still returns a fling direction.Fixes #19434
Test Plan:
inverted={true}.Expected:
On Android 8 and 9 the behaviour is the same.
Release Notes:
[ANDROID] [BUGFIX] [ScrollView] - Workaround a wrong fling direction for inverted ScrollViews on Android P